Redux setup #2
Redux setup #2
Conversation
There was a problem hiding this comment.
Hi @Micky373 ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
TO HIGHLIGHT:
- Your project is professional 馃挴
- Your repo is professional 馃挴
- Well structured files 馃挴
Required Changes 鈾伙笍
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/redux/books/books.js
Outdated
| const ADD_BOOK = 'ADD_BOOK'; | ||
| const REMOVE_BOOK = 'REMOVE_BOOK'; |
There was a problem hiding this comment.
Please ensure that value of each action type follows the ducks pattern, so it will be something like: const ADD_BOOK = bookstore/books/ADD_BOOK and const REMOVE_BOOK = bookstore/books/REMOVE_BOOK
src/redux/catagories/catagories.js
Outdated
| @@ -0,0 +1,16 @@ | |||
| const CHECK_STATUS = 'CHECK_STATUS'; | |||
There was a problem hiding this comment.
Please ensure that value of each action type follows the ducks pattern, so it will be something like: const CHECK_STATUS = bookstore/categories/CHECK_STATUS
| export const addBook = (book) => ({ | ||
| type: ADD_BOOK, | ||
| payload: book, | ||
| }); | ||
|
|
||
| export const removeBook = (id) => ({ | ||
| type: REMOVE_BOOK, | ||
| payload: id, | ||
| }); |
There was a problem hiding this comment.
Your application is not performing as expected, I cannot add books. When I click on the add book button nothing happens. Kindly fix this. As a result of this, I couldn't test your remove book function.
There was a problem hiding this comment.
Hello reviewer, That is the functionality that should be added in the next milestone when we link the react and redux.
We are not supposed to complete that action at this branch.
There was a problem hiding this comment.
Hi @Micky373,
Congratulations! 馃帀
Your project is complete! There is nothing else to say other than... it's time to merge it 馃殌 :
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Reviewer,
In this PR I:
Thanks 馃憤馃徑