Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize the component branch #2

Merged
merged 1 commit into from Mar 23, 2022
Merged

Finalize the component branch #2

merged 1 commit into from Mar 23, 2022

Conversation

Micky373
Copy link
Owner

Hello Reviewer,

In this branch I:

  • Delete all the boilerplates and change them with mine
  • Created a component directory and added the calculator.js file
  • I made a class-based react component in calculator.js
  • I made the design to match the given one
  • Imported my calculator.js in App.js and used it
  • Used App.css to style my page
  • No linter error
  • Used the git flow
  • Used ES6 best practices

Thanks 馃憤馃徑

Copy link

@AshakaE AshakaE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Micky373 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Micky373 Micky373 merged commit 9f6d502 into development Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants