Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

React events #3

Merged
merged 4 commits into from Mar 24, 2022
Merged

React events #3

merged 4 commits into from Mar 24, 2022

Conversation

Micky373
Copy link
Owner

Hello Reviewer,

In this branch I :

  • Created a directory named Logic and copied the calculate and operate javascript files
  • Installed the Big.js dependency using the node package manager
  • Imported the calculate javascript file to my calculator component
  • Implemented the state up and props functionality using a class component
  • Test my app using a browser and works well without any error
  • No linter error
  • Followed the ES6 best practices
  • Followed best practice of git-flow

Thanks 馃憤馃徑

Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 馃帀 馃帀 馃帀 馃嵕 馃嵕 馃嵕

Hi @Micky373,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 馃帀 馃帀 馃帀 馃嵕 馃嵕 馃嵕

Congratulations-Memes-FEATURED

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!馃憦馃憦馃憦

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Micky373 Micky373 merged commit f29960e into development Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants