Finalize full website #5
Conversation
There was a problem hiding this comment.
Hi @Micky373, 馃憢
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes 鈾伙笍
See the inline comments below for more required changes
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <nav> | ||
| <h1 style={HeaderStyle}>Math Magician</h1> | ||
| <ul className="nav_links"> | ||
| <Link to="/"><li>Home</li></Link> | ||
| <Link to="/Calculator"><li>Calculator</li></Link> | ||
| <Link to="/Quotes"><li>Quotes</li></Link> | ||
| </ul> | ||
| </nav> |
There was a problem hiding this comment.
- Kindly try to follow the wireframes that are provided in the project requirements, the name of the project should be on the left of the header and the nav links should be on the right of the header.
There was a problem hiding this comment.
Hi @Micky373 ,
Status: Approved 鉁旓笍
Your project is complete! There is nothing else to say other than... it's time to merge it 馃殺
Congratulations! 馃帀
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Reviewer,
In this branch I :
Thanks 馃憤馃徑