Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email and Planner apps disabled in urls.py #14

Closed
smacktrace opened this issue Jan 24, 2018 · 5 comments
Closed

Email and Planner apps disabled in urls.py #14

smacktrace opened this issue Jan 24, 2018 · 5 comments

Comments

@smacktrace
Copy link

smacktrace commented Jan 24, 2018

You have the email and planner apps commented out in the main crm/urls.py. Is this intentional as you are still developing this CRM? Are you planning to add documentation on how to enable these features at http://django-crm.readthedocs.io ? These features/documentation would be very helpful!

# url(r'^emails/', include('emails.urls', namespace='emails')),
# url(r'^planner/', include('planner.urls', namespace='planner')),
@btenaglia
Copy link

Hello, What is the reason for emails and planners are commented? Are these modules ready to use?

@jeremyklein
Copy link
Contributor

I uncommented these modules and found the following:

  • the email module requires an email server, and fails when trying to send an email. When I have some more time I will try setting up FakeSMTP and seeing how far that goes.

  • The planner module does not seem to work as load_meetings function in the view references a "created_user" and "updated user" field while the model has a "created_by" and "updated_by" field

I can try to get these modules working, but I'm kind of shooting in the dark as to what the functionality is supposed to do. Is there any sort of test plan or set of requirements for these features?

@jeremyklein
Copy link
Contributor

jeremyklein commented Feb 18, 2018

I changed the backend to the Django Dummy backend. This seemed to fix the only issue I found with the email module. There was also a link to an inbox, but I saw no code to implement this feature. I removed the Inbox link from each of the pages. If anyone has some requirements around how the Inbox should would I would be happy to try to implement.

I submitted a pull request with my updates. #16

@ashwin31
Copy link
Member

@smacktrace we planned to develop and release those at a later stage. We will start those and other enhancements as you are interested.

@ashwin31
Copy link
Member

#16 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants