Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Web-Service is very unreliable #103

Closed
novak-services opened this issue Oct 17, 2021 · 6 comments
Closed

The new Web-Service is very unreliable #103

novak-services opened this issue Oct 17, 2021 · 6 comments

Comments

@novak-services
Copy link

Hi,

I am working in a project which uses forex-python regularly. But lately the webservice changed. We updated to 1.6. Since than, we got many troubles.

At first we got the error

RatesNotAvailableError("Currency Rates Source Not Ready")

So I incoporated the change, that was in one commit after the 1.6 release to prevent this error.

But after that, I still got some errors like that:

 RatesNotAvailableError("Currency Rate {0} => {1} not available for Date {2}")

We always access past rates with a date.

I was curious, what the reason was, so I tried to access the API myself. I got some very strange results. Everything seems to be Ok, with latest rates and also at business days. But when I try a non-Business date, it really gets strange.

Here some examples, I got:

4.4.:

 curl "https://theforexapi.com/api/2021-04-04/?base=GBP&symbols=EUR&rtype=fpy"

 Result: {"date":"2021-09-09","base":"EUR","rates":{}}

Particularly be aware here, that the base should be GBP, but is not!

5.4.:

 curl "https://theforexapi.com/api/2021-04-05/?base=GBP&symbols=EUR&rtype=fpy"
 
 Result: {"rates":{"USD":"1.1746"},"date":"2021-04-01","base":"EUR"}

Why do we get here USD? I tried the same call again, and was totally astonished.

5.4 Second Try:

 curl "https://theforexapi.com/api/2021-04-05/?base=GBP&symbols=EUR&rtype=fpy"

 Result: {"rates":{"GBP":"0.85195"},"date":"2021-04-01","base":"EUR"}

So the results are not even stable and I am not sure, if errors due to this unstable results can not lead to wrong rate results, since rates are exchanged and also dates can be wrong (and even more?).

I even tried to use the API without base and symbols, but even than I got wrong results eventually.

So in my opinion this web service is not usable at all in this state. Even when it would not be unstable, on non-working days, this service can not provide results. Working around this would be very cumbersome. But with the instability, even a workaround would be error-prone.

My question here: Why do you use particularly this service and would it be feasible to use a different one?

@abhijeet-1110
Copy link
Collaborator

@novak-services We will check will resolve the issue ASAP

@BerendMosch
Copy link

Has there been any progress on this? The exact same issues still persist.

@qmhedging
Copy link

same "Currency Rates Source Not Ready"

for version 1.8

@ashwin31
Copy link
Member

ashwin31 commented Aug 7, 2022

@qmhedging @BerendMosch @novak-services it is stable now. please check.

@ashwin31
Copy link
Member

ashwin31 commented Aug 7, 2022

I will implement if you find any better service to be used.

@ashwin31 ashwin31 closed this as completed Aug 7, 2022
@ekdevelop
Copy link

Is the website down again? Because i am getting the currencyRatesNot available error on 1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants