Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historic rates not available for several dates #38

Closed
EamonnONeill opened this issue Jun 5, 2018 · 8 comments
Closed

Historic rates not available for several dates #38

EamonnONeill opened this issue Jun 5, 2018 · 8 comments
Assignees

Comments

@EamonnONeill
Copy link

For example https://ratesapi.io/api/2018-05-20?base=USD

Full list of dates not working in the last 365 days:
2018-06-05
2018-06-03
2018-06-02
2018-05-27
2018-05-26
2018-05-20
2018-05-19
2018-05-13
2018-05-12
2018-05-06
2018-05-05
2018-05-01
2018-04-29
2018-04-28
2018-04-22
2018-04-21
2018-04-15
2018-04-14
2018-04-08
2018-04-07
2018-04-02
2018-04-01
2018-03-31
2018-03-30
2018-03-25
2018-03-24
2018-03-18
2018-03-17
2018-03-11
2018-03-10
2018-03-04
2018-03-03
2018-02-25
2018-02-24
2018-02-18
2018-02-17
2018-02-11
2018-02-10
2018-02-04
2018-02-03
2018-01-28
2018-01-27
2018-01-21
2018-01-20
2018-01-14
2018-01-13
2018-01-07
2018-01-06
2018-01-01
2017-12-31
2017-12-30
2017-12-26
2017-12-25
2017-12-24
2017-12-23
2017-12-17
2017-12-16
2017-12-10
2017-12-09
2017-12-03
2017-12-02
2017-11-26
2017-11-25
2017-11-19
2017-11-18
2017-11-12
2017-11-11
2017-11-05
2017-11-04
2017-10-29
2017-10-28
2017-10-22
2017-10-21
2017-10-15
2017-10-14
2017-10-08
2017-10-07
2017-10-01
2017-09-30
2017-09-24
2017-09-23
2017-09-17
2017-09-16
2017-09-10
2017-09-09
2017-09-03
2017-09-02
2017-08-27
2017-08-26
2017-08-20
2017-08-19
2017-08-13
2017-08-12
2017-08-06
2017-08-05
2017-07-30
2017-07-29
2017-07-23
2017-07-22
2017-07-16
2017-07-15
2017-07-09
2017-07-08
2017-07-02
2017-07-01
2017-06-25
2017-06-24
2017-06-18
2017-06-17
2017-06-11
2017-06-10

@arnohakk
Copy link

arnohakk commented Jun 5, 2018

Same issue over here.

@ravigadila
Copy link

@EamonnONeill @arnohakk We are investigating the issue we will solve this ASAP.
@nikhila05 check currency source for above dates.

@nikhila05
Copy link
Contributor

@ravigadila @EamonnONeill @arnohakk Most of the above dates are holidays/weekends. So currency pricess will not be available for the above dates. Our currency resource is https://www.ecb.europa.eu/stats/policy_and_exchange_rates/euro_reference_exchange_rates/html/index.en.html
Please check the csv file in the link for missing dates.

@EamonnONeill
Copy link
Author

@nikhila05 thanks, that makes sense, I should have picked up the weekend.

I believe previously I could request the rates for a weekend/holiday date and it would give me back rates for the last available date. I have daily python processes that download rates for historic dates using python_forex and weekends have never thrown errors before today.

@nikhila05
Copy link
Contributor

@EamonnONeill Recently we moved from fixer.io to ratesapi.io We'll consider your thought and fix above.

@EamonnONeill
Copy link
Author

The change does mean that forex-python now functions differently to before. I'll write a workaround in the mean time anyway. Thanks for the help.

@nikhila05
Copy link
Contributor

@EamonnONeill we've updated the api for holidays/weekends.

If the selected date doesn't have information about currencies, then it returns recent date values from the selected date.

for ex: 2018-05-20 don't have currency information. so it'll return recent date value i.e 2018-05-18 currency information

https://ratesapi.io/api/2018-05-20?base=USD

@EamonnONeill
Copy link
Author

Awesome thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants