Build refactor and bintray plugin replacement

[altavir]

Fix fo #126 #130 #144 and partially #45

[YarnSphere]

Also out of curiosity, why did you undo your Generify native build commit?

[altavir]

The current upstream build already contains a different way to generify the build. So I decided to keep the upstream version.

[YarnSphere]

Fair enough, I'm just more used to the "default" (as in, the one that comes with a newly generated MPP lib) one.

[oshai]

Thanks for the PR. As for the deployment, I guess snapshot releases are the same, how do I perform regular releases? manually?

[altavir]

I do regular releases manually from gradle, but you can trigger the deploy process from CI. Exactly the same way, you were doing for bintray plugin. The only difference is that you have to use publishAllPublicationsToBintrayRepository instead of bintrayUpload. The only difference is that maven-publish does not create bintray package automatically, you need to create it manually before the first time you want to push a new artifact. You have it already so no actions needed.

[altavir]

Fair enough, I'm just more used to the "default" (as in, the one that comes with a newly generated MPP lib) one.

The difference is in naming and tests. I am not sure that native tests are running correctly in this variant. On the bright side, source set naming is the same for different OS.

[YarnSphere]

@altavir, don't know if you saw what I wrote above, what's all the mipt-npm stuff there?

[altavir]

@altavir, don't know if you saw what I wrote above, what's all the mipt-npm stuff there?

Oops. Forgot to clear it out. I will fix it right away. Those are parts of our deploy plugin, I used at first.

[YarnSphere]

Yeah, I thought so, that's why I was asking just to make sure. :)

[YarnSphere]

don't know if you saw what I wrote above

My bad, didn't realise I needed to press "start review" for my comment to be submitted so I didn't actually "write" anything above. :')

[YarnSphere]

@oshai, if you make a snapshot version for testing let me know and I'll give it a go.

[altavir]

@nunocastromartins you can use this one: https://bintray.com/mipt-npm/dev/kotlin-logging/1.11.5-npm. It is exactly the same, only with a different repository name.

[YarnSphere]

Ah, thanks, it works fine! I mean, I was already using another version of your fork for testing IR stuff, so I had no doubts that yours would work.

My offer was mostly to check that @oshai got the publishing to work correctly on his end.

[oshai]

I will create a snapshot to test ASAP.

[oshai]

The snapshot is here: http://oss.jfrog.org/webapp/builds/kotlin-logging/553
Please test it.

[YarnSphere]

Everything seems to be working. :)

Just one question, are you planning to release this as a minor version or version 2.0? I noticed that you named it 1.11.5-SNAPSHOT.

[oshai]

It will be version 2.0, thanks for pointing out!
I hope I will get the new deployment correct.

[oshai]

@altavir - Thank you very much for the PR!

[altavir]

You are welcome. Sadly, I will have to use my fork for now since I work on Windows and I need both mingw and Linux native targets (windows generates them both).

[oshai]

Snapshot for 2.0.0 is here: http://oss.jfrog.org/webapp/builds/kotlin-logging/555

[oshai]

@altavir I wonder if I can build windows version using travis: https://docs.travis-ci.com/user/reference/windows/
Do you know what is the proper way to deploy from multiple builds machines?

[altavir]

@oshai I think that running deploy script from multiple virtual machines with different OSes should do the trick. The build script deploys artifact relevant to the system you are currently using. On windows (at least with WSL installed) it is possible to generate artifacts both for windows and for Linux, so I am deploying everything from the local machine right now. I will play around with multi-system deployment as soon as we finish adding native targets to our libraries.

[oshai]

Created #149 we will see how it goes.

[YarnSphere]

Btw @oshai, forgot to report, build 2.0.0-SNAPSHOT works well on my end.

[oshai]

@altavir trying to publish I get the following error:

FAILURE: Build failed with an exception.

* What went wrong:
Task 'publishAllPublicationsToBintrayRepository' not found in root project 'kotlin-logging'.

Any idea what is missing?
I do see a publish task. Is this the one should be used? Using it doesn't upload the artifacts.

[altavir]

@oshai I think that the problem is with project properties. This line ensures that bintray repository publication is not registered unless bintrayRepo, bintrayUser and bintrayApiKey are all defined in the properties. It seems like bintrayOrg is needed as well. Probably one of those are missing. You probable could hardcode bintrayRepo and bintrayOrg since it is always the same for you, but user and API key should be defined externally.

[oshai]

Thanks, that seems to work!

[oshai]

I released 2.0.2 to bintray and maven central. Will update docs soon.

[oshai]

@altavir do you know if maven central has similar api to the bintray one so the publish plugin can be used for that as well?

[altavir]

@oshai Yes, it should work exactly the same way for maven central, just with a different repository definition. Though maven central has more strict rules about artifact preparation and I never tried that. There are a lot of examples though. Like the official one.