Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include .map files in npm publish output #1492

Closed
wictorwilen opened this issue May 22, 2018 · 3 comments
Closed

Do not include .map files in npm publish output #1492

wictorwilen opened this issue May 22, 2018 · 3 comments
Labels
Projects

Comments

@wictorwilen
Copy link

Currently when bundling adaptive cards through the botframework-webchat npm package you get a set of webpack warnings. Referenced here microsoft/BotFramework-WebChat#974

The way to work around this warning is to delete the .map files in the build output or better remove them when publishing to the npm repository (through the .npmignore file)

wictorwilen added a commit to wictorwilen/AdaptiveCards that referenced this issue May 22, 2018
@pschaeflein
Copy link

Problem also exists when bundling adaptive cards in a SharePoint Framework web part. The fix submitted by Wictor resolves the issue.

@ghost ghost added the Triage-Needed label Jul 24, 2020
@RebeccaAnne RebeccaAnne added this to the Backlog milestone Jul 24, 2020
@ghost ghost added this to Needs triage in Bug Triage Jul 24, 2020
@paulcam206 paulcam206 moved this from Needs triage to Investigate in Bug Triage Jul 31, 2020
@ghost ghost removed the Triage-Needed label Jul 31, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

Hi @wictorwilen. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@RebeccaAnne RebeccaAnne removed this from the Backlog milestone May 6, 2021
@jonmill jonmill added this to P2 in Triage Aug 20, 2021
@jonmill
Copy link
Contributor

jonmill commented Nov 4, 2021

This issue should be fixed in the recent versions of the package; if that is not the case, please re-open the issue and we'll engage. Thanks!

@jonmill jonmill closed this as completed Nov 4, 2021
Triage automation moved this from P2 to Closed Nov 4, 2021
@ghost ghost removed this from Closed in Triage Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Bug Triage
  
Investigate
Development

No branches or pull requests

4 participants