New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTML] Title for choiceset is not trimmed #1797
Comments
@dclaux are you able to look into this? If we make changes here should we also consider using |
I can look into this, and agreed about the label. |
@matthidinger Not sure we've ever addressed this, but should those long strings wrap in Input.Toggle and Input.ChoiceSet, or just be truncated? |
Hmm yeah I don't recall explicitly addressing that. My gut feeling is we should reserve the right to interpret this on each renderer as the experience dictates, so maybe just truncate in most of them, but update our docs with guidance that the choice title should be <30 characters for optimal presentation? |
Truncating is often a bad solution though. If a Toggle or ChoiceSet input is used for a survey, for instance, it is not an option to truncate. |
My requirement is to make it wrapped. Could you please fix for wrapping? |
If I do it here it needs to be done in all other renderers, so it needs to be a concerted decision. We will discuss and come up with a plan. |
Fix for properly truncating is here: #1801 |
Thanks kmkaliraj and David! We can use this thread to track the HTML issue where the text doesn't get clipped correctly. I've opened a new issue #1821 on the topic of whether we should wrap (which would have to be applied to all renderers) |
Closing since the issue has been merged. |
(Edited by andrewleader: Using this to track the bug that the text extends past the boundaries of the Adaptive Card, and we've opened a separate feature to track allowing text wrapping)
Platform
Bot Framework
Web chat
What platform is your issue or question related to? (Delete other platforms).
Author or host
Are you an author (like sending something to Outlook), or a host that is rendering your own cards?
If you're an author, who are you sending cards to?
Version of SDK
What version are you using? Ex: NuGet 1.0.2, or latest master, etc...
Issue
Explain your issue. If you just have a question, please post on StackOverflow instead.
The text was updated successfully, but these errors were encountered: