Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML] Title for choiceset is not trimmed #1797

Closed
kmkaliraj opened this issue Aug 14, 2018 · 10 comments
Closed

[HTML] Title for choiceset is not trimmed #1797

kmkaliraj opened this issue Aug 14, 2018 · 10 comments
Labels
Area-Renderers Bug Platform-JavaScript Bugs or features related to the JavaScript renderer

Comments

@kmkaliraj
Copy link

kmkaliraj commented Aug 14, 2018

(Edited by andrewleader: Using this to track the bug that the text extends past the boundaries of the Adaptive Card, and we've opened a separate feature to track allowing text wrapping)

Platform

Bot Framework
bug
Web chat
What platform is your issue or question related to? (Delete other platforms).

  • .NET HTML
  • .NET WPF
  • Android
  • iOS
  • JavaScript
  • UWP

Author or host

Are you an author (like sending something to Outlook), or a host that is rendering your own cards?

If you're an author, who are you sending cards to?

Version of SDK

What version are you using? Ex: NuGet 1.0.2, or latest master, etc...

Issue

Explain your issue. If you just have a question, please post on StackOverflow instead.

@kmkaliraj kmkaliraj changed the title Title for choiceset is not wrapped. It comes out of the adapative card Title for choiceset is not wrapped Aug 14, 2018
@matthidinger matthidinger added Area-Renderers Platform-JavaScript Bugs or features related to the JavaScript renderer labels Aug 15, 2018
@matthidinger
Copy link
Member

@dclaux are you able to look into this? If we make changes here should we also consider using <label for="X" /> to improve the user experience and allow the user to tap on the text itself as opposed to just the radio and checkbox?

@dclaux
Copy link
Member

dclaux commented Aug 15, 2018

I can look into this, and agreed about the label.

@dclaux
Copy link
Member

dclaux commented Aug 15, 2018

@matthidinger Not sure we've ever addressed this, but should those long strings wrap in Input.Toggle and Input.ChoiceSet, or just be truncated?

@matthidinger
Copy link
Member

Hmm yeah I don't recall explicitly addressing that. My gut feeling is we should reserve the right to interpret this on each renderer as the experience dictates, so maybe just truncate in most of them, but update our docs with guidance that the choice title should be <30 characters for optimal presentation?

@dclaux
Copy link
Member

dclaux commented Aug 15, 2018

Truncating is often a bad solution though. If a Toggle or ChoiceSet input is used for a survey, for instance, it is not an option to truncate.

@kmkaliraj
Copy link
Author

My requirement is to make it wrapped. Could you please fix for wrapping?

@dclaux
Copy link
Member

dclaux commented Aug 15, 2018

If I do it here it needs to be done in all other renderers, so it needs to be a concerted decision. We will discuss and come up with a plan.

@dclaux
Copy link
Member

dclaux commented Aug 15, 2018

Fix for properly truncating is here: #1801

@andrewleader
Copy link
Contributor

Thanks kmkaliraj and David! We can use this thread to track the HTML issue where the text doesn't get clipped correctly.

I've opened a new issue #1821 on the topic of whether we should wrap (which would have to be applied to all renderers)

@andrewleader andrewleader changed the title Title for choiceset is not wrapped [HTML] Title for choiceset is not trimmed Aug 22, 2018
@khouzam
Copy link

khouzam commented Sep 10, 2018

Closing since the issue has been merged.

@khouzam khouzam closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Renderers Bug Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Development

No branches or pull requests

5 participants