on anchor clicked contract change #1924
Conversation
Currently, adaptiveCard instance is passed to handle anchor click. Change here is to pass text block element from which adaptiveCard instance can be derived
|
Please also update the visualizer application which uses this feature. |
| function raiseAnchorClickedEvent(element: CardElement, anchor: HTMLAnchorElement): boolean { | ||
| let card = element.getRootElement() as AdaptiveCard; | ||
| function raiseAnchorClickedEvent(textBlock: TextBlock, anchor: HTMLAnchorElement): boolean { | ||
| let card = textBlock.getRootElement() as AdaptiveCard; |
There was a problem hiding this comment.
There is no need to change this. Please keep it as CardElement. We may support inline actions in elements that are not TextBlock in the future.
| @@ -5417,7 +5417,7 @@ export class AdaptiveCard extends ContainerWithActions { | |||
| return true; | |||
| } | |||
|
|
|||
| onAnchorClicked: (rootCard: AdaptiveCard, anchor: HTMLAnchorElement) => boolean = null; | |||
| onAnchorClicked: (textBlock: TextBlock, anchor: HTMLAnchorElement) => boolean = null; | |||
| @@ -5325,7 +5325,7 @@ export class AdaptiveCard extends ContainerWithActions { | |||
| static readonly elementTypeRegistry = new ElementTypeRegistry(); | |||
| static readonly actionTypeRegistry = new ActionTypeRegistry(); | |||
|
|
|||
| static onAnchorClicked: (rootCard: AdaptiveCard, anchor: HTMLAnchorElement) => boolean = null; | |||
| static onAnchorClicked: (textBlock: TextBlock, anchor: HTMLAnchorElement) => boolean = null; | |||
| @@ -5325,7 +5325,7 @@ export class AdaptiveCard extends ContainerWithActions { | |||
| static readonly elementTypeRegistry = new ElementTypeRegistry(); | |||
| static readonly actionTypeRegistry = new ActionTypeRegistry(); | |||
|
|
|||
| static onAnchorClicked: (textBlock: TextBlock, anchor: HTMLAnchorElement) => boolean = null; | |||
| static onAnchorClicked: (elementd: CardElement, anchor: HTMLAnchorElement) => boolean = null; | |||
Realized that changes are required in designer as well. Made the appropriate changes |
| var regEx = /^action:([a-z0-9]+)$/ig; | ||
|
|
||
| var rootCard = element.getRootElement(); |
There was a problem hiding this comment.
We should check that this is an AdaptiveCard. getRootElement returns a CardElement.
| var regEx = /^action:([a-z0-9]+)$/ig; | ||
| var rootCard = element.getRootElement(); |
There was a problem hiding this comment.
Should check that this is actually an AdaptiveCard instance.
There was a problem hiding this comment.
making var rootCard = element.getRootElement() as AdaptiveCard works?
There was a problem hiding this comment.
Yes that should be enough given there is a if (rootCard) statement after.
Currently, adaptiveCard instance is passed to handle anchor click. Change here is to pass text block element from which adaptiveCard instance can be derived if required.