Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React native implementation of Adaptive card #2193

Merged
merged 296 commits into from Apr 9, 2019
Merged

React native implementation of Adaptive card #2193

merged 296 commits into from Apr 9, 2019

Conversation

Vasanth-S
Copy link
Contributor

High level notes on implementation


We have built the,

  • leaf components that can work as standalone based on the given props.
  • container components
  • AdaptiveCard that takes care of initial parsing & component creations
  • HostConfig system

@matthidinger
Copy link
Member

Hi @Vasanth-S, thanks for submitting this! A fellow Microsoft team recently published their version of a react-native renderer as well: https://github.com/Microsoft/react-native-adaptivecards

Can you help us understand the state of this renderer? Are you folks actively planning to maintain it and keep it in line with future adaptive cards releases? Ideally we can find some way to coordinate efforts and maintain a single react-naive implementation if at all possible

@Vasanth-S
Copy link
Contributor Author

Vasanth-S commented Nov 30, 2018

Hi @matthidinger, Appreciate the quick response. Please find below the report for the state of this renderer with due date marked for few minor items.

Adaptive Cards React-Native Renderer Status

Card Rendering Functionality Completed / Planned Date
Card Rendering
Render full schema
Render actions bar
Ignore unknown Elements
Host Config support
Native platform styling
Check for supported version
Element Rendering
Spacing and Separator
TextBlock DATE/TIME formatting
TextBlock Markdown support
Full Input support
Actions
Action.OpenUrl support
Action.ShowCard support
Action.Submit support
selectAction support
Parsing
Return validation failures
Parse unknown properties
Extensbility
Override Element Renderer
Add new Element Renderer
Remove Element Renderer
Override/add/remove Action Renderer
Events
Element visibility changed

We're committed to maintaining it and add new features (as per the roadmap).

We will also share our fork/status on the repo board. Happy to get on a call for a discussion, if needed.

raghunandhan.chikoti@imaginea.com and others added 28 commits December 13, 2018 15:02
Add Android build.gradle file
[Issue] - Fix to render image  when  height is `stretch`
BalajiR and others added 26 commits April 3, 2019 18:41
RichTextBlock Action added for the markdown formatter
Updated version and renamed root component.
Merging the dev branch with Master
[Refactor] : Moved Spacing/Separator as an element
Merge development branch with master
Container Styles Implementation modified to suit the new changes in host-config
Dev 1.2 - Bleed property and ActionSet features
Copy link
Member

@matthidinger matthidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited to finally get to aprove this! Thanks a ton for your contributions and can't wait to get the community access to this!

@Vasanth-S Vasanth-S self-assigned this Apr 9, 2019
@paulcam206
Copy link
Member

Some checks didn't run, but as this is a new project, they're not important.

:shipit:

@paulcam206 paulcam206 merged commit 6a97694 into microsoft:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants