[.NET][WPF][HTML] Fix bleed bugs #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the description to contain a brief description of what the issues were? |
paulcam206
approved these changes
Apr 17, 2019
| } | ||
| else | ||
| { | ||
| if (i == 0) |
There was a problem hiding this comment.
consider creating local variables that represent the logic here to make the intent more obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue: #2680
The biggest issue was that our sample cards were not being properly rendered as they would sometimes overflow, mainly in the columnset inside another columnset case
How verified
WPF
Nested.ColumnSet.Bleed.json
Nested.ColumnSet.Bleed.Complex.json
ComprehensiveTest.json
Column.ColumnSet.Container.Bleed.json
HTML
The tests cards were run and it gave this results
ColumnColumnSetContainer.Bleed.json