Skip to content

Commit

Permalink
Merge pull request #880 from Microsoft/fix/min-db-size
Browse files Browse the repository at this point in the history
Min database size changed with index
  • Loading branch information
guperrot committed Nov 16, 2018
2 parents 11b2276 + c013ac8 commit 0438f8a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

* **[Fix]** Do not delete old logs when trying to add a log larger than the maximum storage capacity.

### AppCenter

* **[Fix]** Fix minimum storage size verification to match minimum possible value.

### AppCenterCrashes

* **[Fix]** Fix a bug where crash data file could leak when the database is full.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,10 @@ public class AppCenter {
static final long DEFAULT_MAX_STORAGE_SIZE_IN_BYTES = 10 * 1024 * 1024;

/**
* Minimum size allowed for set maximum size (SQL limitation). setMaxStorageSize could accept values
* as low as 16385 but in practice the lowest size set is the next highest multiple of 4096.
* Minimum size allowed for set maximum size (SQL limitation).
*/
@VisibleForTesting
static final long MINIMUM_STORAGE_SIZE = 20480;
static final long MINIMUM_STORAGE_SIZE = 24 * 1024;

/**
* Group for sending logs.
Expand Down

0 comments on commit 0438f8a

Please sign in to comment.