Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #1283

Merged
merged 6 commits into from Oct 18, 2019
Merged

Fix flaky test #1283

merged 6 commits into from Oct 18, 2019

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Oct 17, 2019

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

Trying to fix a flaky test.

dhei
dhei previously approved these changes Oct 17, 2019
@coveralls
Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d6b9c77 on fix/flaky-test into 26718db on develop.

@dhei dhei closed this Oct 17, 2019
@dhei dhei reopened this Oct 17, 2019
@guperrot guperrot closed this Oct 18, 2019
@guperrot guperrot reopened this Oct 18, 2019
@guperrot
Copy link
Member Author

reopened because the build never started

@guperrot
Copy link
Member Author

Screen Shot 2019-10-17 at 5 53 34 PM

@MatkovIvan
Copy link
Contributor

@guperrot Could you please mention somewhere what exactly test is flaky?
Does it fix saveWrapperException?

@dhei dhei merged commit bd429f9 into develop Oct 18, 2019
@dhei dhei deleted the fix/flaky-test branch October 18, 2019 17:04
@guperrot
Copy link
Member Author

guperrot commented Oct 18, 2019

@guperrot Could you please mention somewhere what exactly test is flaky?
Does it fix saveWrapperException?

Yeah at first it was that, then disabling log sending in the android test uncovered some lines in the http logic.

If the test was fast enough to send logs and get an error, it would delete files as error is unrecoverable.
In most cases it was fast enough always to trigger the onPreExecute (but not go through completion) and was covering sending an http log without token and the onStart thing that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants