Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature branch for in app update changes to tracking #1352

Merged
merged 72 commits into from Feb 11, 2020
Merged

Feature branch for in app update changes to tracking #1352

merged 72 commits into from Feb 11, 2020

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Jan 17, 2020 •
edited

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

See AB#75273

@guperrot guperrot force-pushed the feature/in-app-update-track branch 3 times, most recently from 3d182ae to 82bd608 Compare January 17, 2020 22:14
@coveralls
Copy link

coveralls commented Jan 17, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 3470655 on feature/in-app-update-track into f808999 on develop.

guperrot and others added 25 commits January 17, 2020 15:13
@guperrot
Make public in-app updates the default and not require browser
c9a4e9e 
We need a new API to avoid passing a specific group id, this is is WIP
@guperrot
Implement setInUpdateTrack, allowing before start
869d4d4
@guperrot
Allow runtime switch between public/private groups
bb85081 
Also fix switching from private to public while keeping token.
@guperrot
Implement spec change to setter
146eafd
@guperrot
Add getter and fix persistence / change
3411b36
@guperrot
Fix a comment
4e60fee
@guperrot
Change enum values to be future proofs if we combine them as flags
1b99afd
@guperrot
Reset last update track check on disable
0a0055e
@guperrot
Fix null pointer
798ce25
@guperrot
Fix some of the unit tests
58a876c
@guperrot
Fix more unit tests
ad8fef1
@guperrot
Add some unit tests
ad6342d
@guperrot
Add tests
ec2336b
@guperrot
Add another test
d0d8c71
@guperrot
Add a test
153a50f
@guperrot
Add missing test
0533d20
@guperrot
Fix new lint error on CI that appears after upgrading azure pipelines…
bc3e5cc 
… somehow
add UI to switch between Public and Private update track
eb8eb2b
use reflection
4c1f587
@guperrot
Merge pull request #1353 from microsoft/feature/set-in-app-update-track
e1b81b9 
Set/get in update track
@guperrot
Fix distribute start session log for public track
381de02
@guperrot
Add more verifications
0c48561
@guperrot
Apply suggestions from code review
68e55c6 
Co-Authored-By: Guillaume Perrot <guperrot@microsoft.com>
add update track before start UI controls
a05e94d
@guperrot
Merge pull request #1356 from microsoft/feature/inappupdatetrack-fix-…
c0110dd 
…public-stats

Feature/inappupdatetrack fix public stats
owlstronaut and others added 19 commits January 30, 2020 11:40
@owlstronaut
Merge remote-tracking branch 'origin/feature/in-app-update-track' int…
12bf703 
…o feature/new-distribute-endpoints
@owlstronaut
remove comment
975e71e
@owlstronaut
Browser is only used for private now, don't need non-private url
15d4a5f
@owlstronaut
Use current distributionGroupId again
87b61e1
@owlstronaut
run formatter
b8c4017
@owlstronaut
Pass distributionGroupid through
182ea6d
@owlstronaut
Added back java doc
21d2afb
@owlstronaut
Merge pull request #1360 from microsoft/feature/new-distribute-endpoints
64aa368 
Use new endpoints for private setup, public in-app updates
@guperrot
Allow change to update track only before start
37eeab1
@guperrot
Update UI to only update track before start
e51dda4
@guperrot
Fix existing unit tests
ca1adf2
@guperrot
Update error message
fa63319
@guperrot
Fix a warning
90fb117
@guperrot
Fix other unit tests
f828bb7
@guperrot
Add a toast for next start change of update track
89c0c4e
@guperrot
Update sdk/appcenter-distribute/src/main/java/com/microsoft/appcenter…
a218290 
…/distribute/Distribute.java
Update changelog
2223024
@jaeklim
Merge pull request #1361 from microsoft/feature/in-app-update-track-b…
2390928 
…efore-start-only

Feature/in app update track before start only
@dhei
Merge pull request #1363 from microsoft/in-app-updates-changelog
bae77c6 
In app updates changelog
@guperrot guperrot marked this pull request as ready for review February 4, 2020 23:04
jaeklim
jaeklim previously approved these changes Feb 8, 2020
View reviewed changes
@guperrot guperrot merged commit ccdd047 into develop Feb 11, 2020
@guperrot guperrot deleted the feature/in-app-update-track branch February 11, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeklim jaeklim jaeklim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guperrot @coveralls @jaeklim @owlstronaut @dhei