Add strong typing to common event properties #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test app U.I. in a separate PR.
|
#833 should be approved before merging this |
jaeklim
approved these changes
Oct 9, 2018
dhei
reviewed
Oct 9, 2018
| target.getPropertyConfigurator().setEventProperty("myNullString", (String) null); | ||
| target.getPropertyConfigurator().setEventProperty("myTrue", true); | ||
| target.getPropertyConfigurator().setEventProperty("myFalse", false); | ||
| target.getPropertyConfigurator().setEventProperty("myLong", 123); |
There was a problem hiding this comment.
Use a real long value between 2^32 and 2^64-1 for long type
dhei
reviewed
Oct 9, 2018
| target.getPropertyConfigurator().setEventProperty("myLong", 123); | ||
| target.getPropertyConfigurator().setEventProperty("myDate", new Date(456)); | ||
| target.getPropertyConfigurator().setEventProperty("myNullDate", (Date) null); | ||
| target.getPropertyConfigurator().setEventProperty("myDouble", -3.14); |
There was a problem hiding this comment.
Add a case for scientific notation of double like "1.2345e" would be great
There was a problem hiding this comment.
Another method has a simple double so will just change this one
guperrot
changed the base branch from
feature/event-typed-properties-transmission-target
to
feature/event-typed-properties
dhei
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test app U.I. in a separate PR.