Add flags to AnalyticsTransmissionTarget.trackEvent(String, Map) #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeklim
previously approved these changes
Nov 8, 2018
dhei
reviewed
Nov 8, 2018
| * @param name An event name. | ||
| * @param properties Optional properties. | ||
| * @param flags Optional flags. Use {@link Flags#PERSISTENCE_CRITICAL} to send this event | ||
| * before events using that use default flags or {@link Flags#PERSISTENCE_NORMAL}. |
There was a problem hiding this comment.
wording can be improved, maybe something like:
Use {@link Flags#PERSISTENCE_CRITICAL} to send this event before other events with {@link Flags#PERSISTENCE_NORMAL} or default flags.
There was a problem hiding this comment.
Let's just align with Apple then: microsoft/appcenter-sdk-apple#1208 (comment)
dhei
previously approved these changes
Nov 8, 2018
guperrot
suggested changes
Nov 8, 2018
...h/src/projectDependency/java/com/microsoft/appcenter/sasquatch/activities/EventActivity.java
Show resolved
Hide resolved
Uses null typed properties in that case like documented.
guperrot
previously approved these changes
Nov 8, 2018
dhei
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdbeen updated?Related PRs or issues
#870