Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting UserID in App Center SDK #894

Closed
wants to merge 53 commits into from
Closed

Support setting UserID in App Center SDK #894

wants to merge 53 commits into from

Conversation

thyeggman
Copy link
Contributor

@thyeggman thyeggman commented Nov 26, 2018 •
edited

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

Allow a user to be set and associated with crashes, errors, and telemetry logs.

Related PRs or issues

#890 #891 #884 #887 #888 #889

guperrot and others added 30 commits November 14, 2018 19:23
@guperrot
Implement userId in AppCenter crashes
0d6712f
@guperrot
Extract minidump processing in a method
d41a173
@guperrot
Merge pull request #878 from Microsoft/feature/userid-crash
0f818ad 
Implement userId in AppCenter crashes
@dhei
Add getUserId API to PartAUtils conversion
1ec6b83
@dhei
Merge remote-tracking branch 'origin/feature/userid' into feature/use…
349be69 
…rid-common-schema
@thyeggman
Adding user ID t oapp extension and adding tests
9be8e1c
@thyeggman
Update PartAUtils and placeholder for OneCollector validation
74d8b71
@guperrot
Use ext.app.userId instead of ext.user.localId and do validation
fd9bc8a
@guperrot
Add more tests
a6ee86d
@guperrot
Test serialization of common schema user ids
432c37c
@guperrot
Fix error message
0b69ca2
@guperrot
Merge pull request #885 from Microsoft/develop
ec8c0b9 
Merge develop to userId feature
@guperrot
Merge remote-tracking branch 'origin/feature/userid' into feature/use…
1ec73d5 
…rid-common-schema
@guperrot
Address feedbacks and fix code analysis
c580894
@guperrot
Add setAppUserId on PropertyConfigurator
df009e1
@guperrot
Merge pull request #884 from Microsoft/feature/userid-common-schema
3bb5384 
Send ext.app.userId to One Collector for the default target
@MatkovIvan
Add user id setting
2344fed
@MatkovIvan
Fix jcenter dependency
b4d2eea
@MatkovIvan
Implement UI to test userId on AnalyticsTransmissionTarget
aec86fd
@guperrot
Merge pull request #887 from Microsoft/feature/userid-ui
b154a71 
Implement UI to test userId on AppCenter
@guperrot
Merge remote-tracking branch 'origin/feature/userid' into feature/use…
48d8d2d 
…rid-transmission-target
@guperrot
Test app userId alongside other fields in existing unit tests
cdc6e31
@thyeggman
Adding tests for invalid/unset userID
c932cec
@thyeggman
Merge remote-tracking branch 'origin/feature/userid-transmission-targ…
f8429ee 
…et' into feature/userid-transmission-target-ui
@thyeggman
Adding toast to property configuration
27b1514
@thyeggman
Merge pull request #889 from Microsoft/feature/userid-transmission-ta…
e0039f1 
…rget

Add UserId to property configurator for transmission targets
@thyeggman
Adding blank line before comment
374a2be
@thyeggman
Merge pull request #888 from Microsoft/feature/userid-transmission-ta…
c1b5287 
…rget-ui

Implement UI to test userId on AnalyticsTransmissionTarget
@guperrot
Implement latest spec for userId
af585a5
@guperrot
Refactoring
68b37f3
thyeggman and others added 23 commits November 21, 2018 09:49
@thyeggman
Updating tests and test app
db58ca3
@thyeggman
Added test class for UserID utils and fixed utils
fc63475
@thyeggman
More refactoring and test fixes
cd17a69
@thyeggman
Reformatting modified files
3de8588
@thyeggman
Fixing coverage
416fe09
@guperrot
Fix prefix management
0f28c07
@thyeggman
Adding more utils test
3bc577e
@thyeggman
Fix merge conflict
b92302b
@guperrot
Fix prefix management bis
83423ae
@thyeggman
Moving constant to util file
60fda21
@thyeggman
Merge branch 'feature/user-localid' of https://github.com/Microsoft/A…
ce79d2c 
…ppCenter-SDK-Android into feature/user-localid
@guperrot
Fix error message
37015e5
@guperrot
Work in progress to refactor shared user id
16839e3
@thyeggman
Fixing auto-refactor
912c417
@guperrot
Cleanup userId after crash test
f809910
@guperrot
Remove obsolete instance
3116a9b
@MatkovIvan
Merge pull request #893 from Microsoft/develop
3176e28 
Merge develop to userid
@guperrot
Merge pull request #891 from Microsoft/feature/shared-userid
b6e4d21 
Refactor UserIdUtil into UserIdContext
@guperrot
Merge remote-tracking branch 'origin/feature/userid' into feature/use…
801befc 
…r-localid
@guperrot
Address feedbacks
d7238ec
@guperrot
Address feedback
c68ffbe
@guperrot
Address feedback
5381ead
@thyeggman
Merge pull request #890 from Microsoft/feature/user-localid
fb00e84 
Updating setUserId APIs to match new spec
@thyeggman thyeggman changed the title Feature/userid Support setting UserID in App Center SDK Nov 26, 2018
@thyeggman thyeggman closed this Nov 26, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fb00e84 on feature/userid into f73654a on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thyeggman @coveralls @guperrot @dhei @MatkovIvan