Addition to #932 #937
Merged
Addition to #932 #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* First error, try to delete database (may be corrupted). */ | ||
| mContext.deleteDatabase(mDatabase); | ||
| if (mContext.deleteDatabase(mDatabase)) { |
There was a problem hiding this comment.
We should document this behavior to let customers know that we only ever delete data to recover from this fatal error scenario.
ElektrojungeAtWork
approved these changes
Jan 28, 2019
annakocheshkova
approved these changes
Jan 28, 2019
thyeggman
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdbeen updated?Description
Addition to #932
Related PRs or issues
#932