Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

use Interfaces references instead of real pakages #72

Merged
merged 1 commit into from
May 9, 2015
Merged

use Interfaces references instead of real pakages #72

merged 1 commit into from
May 9, 2015

Conversation

SergeyKanzhelev
Copy link
Contributor

Address #69

@abaranch
Copy link
Contributor

abaranch commented May 9, 2015

Approved

SergeyKanzhelev pushed a commit that referenced this pull request May 9, 2015
Merge pull request #72 from Microsoft/sergkanz/useReferences
89c75a0 
use Interfaces references instead of real pakages
@SergeyKanzhelev SergeyKanzhelev merged commit 89c75a0 into develop May 9, 2015
@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/useReferences branch May 9, 2015 02:57
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request May 9, 2015
Closed
@Eilon
Copy link
Member

Eilon commented May 9, 2015

Is it possible to change the reference to Microsoft.AspNet.Mvc.Core to be Microsoft.AspNet.Mvc.Abstractions? More info here: aspnet/Announcements#16

@rynowak to see if he has thoughts on that.

@rynowak
Copy link
Member

rynowak commented May 9, 2015

There's no .Mvc.Abstractions in beta4 - also looks like this code https://github.com/Microsoft/ApplicationInsights-aspnet5/blob/master/src/Microsoft.ApplicationInsights.AspNet/Extensions/ApplicationInsightsJavaScriptExtensions.cs#L14 defines an extension method for IHtmlHelper so .Abstractions is a no-go for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SergeyKanzhelev @abaranch @Eilon @rynowak @msftclas