Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

EventCounters are reported under PerformanceCounter as opposed to CustomMetric #1280

Closed
cijothomas opened this issue Oct 2, 2019 · 0 comments
Assignees
Milestone

Comments

@cijothomas
Copy link
Contributor

EventCounters are currently reported with a special property "customPerfCounter"=true, which makes back end treat it as a PerformanceCounter. This logic exists in back end to maintain backward compatibility, when PerformanceCounter type was deprecated in favor of MetricTelemetry, to ensure performance counters collected by PerformanceCounterModule continues to appear in perfcounter table.

There is no backward compatibility issue with EventCounter, and it should be reported under customMetrics, like any other regular metric.

Though we just shipped the very 1st EventCounter collection module (2.11.0), I propose to fix this in 2.11.1, before bigger customer adoption.

The docs current state EventCounters appear under PerformanceCounter, and it must be corrected as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant