Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sergkanz/task timer deprecation #437

Merged
merged 2 commits into from Feb 17, 2017

Conversation

SergeyKanzhelev
Copy link
Contributor

There is no place for TaskTimer class in Application Insights API. It was implemented before.

TaskTimer is defined in the Microsoft.ApplicationInsights assembly because it is still used here as well as in other AI packages that depend on it. However, it doesn't need to be public anymore because we no longer publish WinRT assemblies. The class was implemented as public because WinRT didn't support internal class visibility at the time. Instead we placed it in the "Implementation" namespace and decided that semver does not apply to public types in this namespace. It should be safe to make TaskTimer internal straight away.

@cijothomas
Copy link
Contributor

@macrogreg
You may need to close this PR and make changes to the updated code instead. #375

@SergeyKanzhelev SergeyKanzhelev merged commit f5ff412 into develop Feb 17, 2017
@TimothyMothra TimothyMothra deleted the sergkanz/TaskTimerDeprecation branch April 17, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants