Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Metadata Changes to Certificates (which do not modify the certificate itself) are not captured #172

Open
guyacosta opened this issue May 1, 2019 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@guyacosta
Copy link
Contributor

guyacosta commented May 1, 2019

Describe the bug
Open the user certificate managed and change some properties after first creating a base scan. Run another and note the changes are not detected. It appears some properties are not captured for comparison which could be by design? But some key ones like OCSP checking being disabled are important from a security standpoint.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a certificate and edit the properties
  2. Change the friendly name i.e. DO_NOT_TRUST to DO_TRUST, change the cert purposes or disable the OCSP checks if enabled or change the extended validation for example. Save and run a scan to compare to a baseline scan.
  3. Note the changes are not detected

Expected behavior
Modification of key properties should be detected. Might be a good idea to document if not in scope for the current release and convert this to an enhancement.

Screenshots
If applicable, add screenshots to help explain your problem.
modifycertname
modifycertocsp

System Configuration (please complete the following information):

  • OS: Windows
  • OS Version: Windows 10
  • Application Version: 2.1...see image
  • CLI or GUI: GUI

Additional Context
Add any other context about the problem here.

@guyacosta guyacosta added the bug Something isn't working label May 1, 2019
@gfs
Copy link
Contributor

gfs commented May 1, 2019

We don't do any "modified" checks for certificates right now. This is a good suggestion for enhancement for 2.1.

@gfs gfs added enhancement New feature or request and removed bug Something isn't working labels May 1, 2019
@gfs gfs added this to the v2.1 milestone May 1, 2019
@gfs gfs changed the title Some Certificate Changed Properties Not Detected Certificate 'Modifications' In Windows are not detected May 2, 2019
@gfs
Copy link
Contributor

gfs commented May 2, 2019

I'm also not sure if that data being changed actually changes the Certificate or if instead it changes how Windows handles the certificate. I'm inclined to believe it is the latter as "modifying" the certificate itself doesn't make sense, given the signing and hashing. Either way this does appear to affect attack surface so it would be nice to collect this. Will investigate what can be done for 2.1.

@guyacosta
Copy link
Contributor Author

Good with that.

@gfs
Copy link
Contributor

gfs commented Sep 10, 2019

I haven't been able to make any headway on this. Moving it to Future, but I can't find any programmatic way to get those settings.

@gfs gfs modified the milestones: v2.1, Future Sep 10, 2019
@gfs gfs changed the title Certificate 'Modifications' In Windows are not detected Windows Metadata Changes to Certificates (which do not modify the certificate itself) are not captured Apr 15, 2020
@gfs gfs removed their assignment Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants