Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IModuleOptions errorCallback type doesn't match documentation #34

Closed
jordan-schneider opened this issue Aug 17, 2018 · 3 comments
Closed

Comments

@jordan-schneider
Copy link

In the documentation for ModuleOptions it says that errorCallback's type is function(errorMessage:string): void, but in this library it's type is () => void. Which is correct?

@drwestco
Copy link

The documentation is correct.

Microsoft.Maps.loadModule('Dennis', { errorCallback: function (msg) { alert(msg) } });
> Dennis is not a supported module.

@improving-jeffd
Copy link

Thanks for merging in that pull request! Do you know when this will release to npm? Not sure what the repo's setup is for publishing updates.

@rbrundritt
Copy link
Member

Not sure if or when it will be merged into NPM. I moved off the Bing Maps team 4 years ago and have been focused on growing the Azure Maps platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants