Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot builder SDK C# does not support the new datetimeV2 time in LUIS entities in (builtin.datetimeV2.timerange) #2764

Closed
m-ehxan opened this issue May 14, 2017 · 7 comments

Comments

@m-ehxan
Copy link

m-ehxan commented May 14, 2017

Bot builder SDK version 3.5.9 does not support the new datetimeV2. when are we expecting next relase.
I want to extract start and end time values in following JSON:

{ "entity": "from 4 pm to 6 pm", "type": "builtin.datetimeV2.timerange", "startIndex": 69, "endIndex": 85, "resolution": { "values": [ { "timex": "(T16,T18,PT2H)", "type": "timerange", "start": "16:00:00", "end": "18:00:00" } ] } },

@nwhitmont nwhitmont added .NET SDK bug Indicates an unexpected problem or an unintended behavior. labels May 15, 2017
@nwhitmont
Copy link
Contributor

nwhitmont commented May 15, 2017

@m-ehxan Can you upgrade BotBuilder nuget package to the current version (v3.8.x) and let me know if you are still experiencing the issue?

@m-ehxan
Copy link
Author

m-ehxan commented May 15, 2017

@nwhitmont I have update the nuget package to (v3.8.0) and i still can not access the start and end time values. In SDK Resolution is defined as public IDictionary<string, object> Resolution { get; set; } and there is no way to directly access the values of timex , type , start or end keys

@msft-shahins msft-shahins added enhancement and removed bug Indicates an unexpected problem or an unintended behavior. labels May 15, 2017
@m-ehxan m-ehxan changed the title Bot builder SDK version 3.5.9 C# does not support the new datetimeV2 time in LUIS entities in (builtin.datetimeV2.timerange) Bot builder SDK C# does not support the new datetimeV2 time in LUIS entities in (builtin.datetimeV2.timerange) May 17, 2017
@ejadib
Copy link
Contributor

ejadib commented Jun 14, 2017

Just for the record, this is also discussed at https://stackoverflow.com/questions/44552030/json-serializer-error-with-botframework-an-luis and https://stackoverflow.com/questions/44544059/problems-mapping-in-luis-entities-into-form-flow

@ejadib
Copy link
Contributor

ejadib commented Jun 15, 2017

I just completed the work to add support for the new entity. Tomorrow I will create a PR for this.

@tellarin
Copy link

@stevengum97, can you close this? :)

@stevengum
Copy link
Member

Thank you @tellarin and @JasonSowers!

@JasonSowers
Copy link
Contributor

You're welcome @stevengum97!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants