Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET SDK] Add JSONConverter to support builtin.datetimeV2.* LUIS entities #2964

Merged
merged 3 commits into from
Jul 21, 2017

Conversation

ejadib
Copy link
Contributor

@ejadib ejadib commented Jun 16, 2017

This PR is intended to fix issue #2764.

FYI @msft-shahins @chrimc62

@ejadib ejadib changed the title Add JSONConverter to support builtin.datetimeV2.* LUIS entities [C# SDK] Add JSONConverter to support builtin.datetimeV2.* LUIS entities Jun 16, 2017
@ejadib ejadib changed the title [C# SDK] Add JSONConverter to support builtin.datetimeV2.* LUIS entities [.NET SDK] Add JSONConverter to support builtin.datetimeV2.* LUIS entities Jun 16, 2017
@willportnoy
Copy link
Member

@ejadib there can be more than one meaningful item - can you update the pull request to deserialize all of them into a list of some type (e.g. IDictionary<string, object>)?

Is there a method to have newtonsoft deserialize JArray into List?

@nwhitmont
Copy link
Contributor

@ejadib Any updates on the LUIS datetime v2 progress?

@msft-shahins msft-shahins self-assigned this Jul 10, 2017
@pcostantini
Copy link
Contributor

Hi @willportnoy , @nwhitmont .
The PR is now updated to also resolve entity's resolution multiple values

image

Regards,
-PabloC.

@willportnoy willportnoy merged commit b73e219 into microsoft:develop Jul 21, 2017
@garypretty
Copy link
Contributor

Is this in the latest NuGet Bot Builder package now? If so do you have a code sample of how to use it to simply get a date value out of an entity?

@ejadib
Copy link
Contributor Author

ejadib commented Oct 19, 2017

I created a set of extension methods to extract the values https://github.com/ejadib/LUIS-DateTimeV2-Extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants