Skip to content

Commit

Permalink
Merge 664a2f7 into 484e2a6
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyanziano committed May 1, 2019
2 parents 484e2a6 + 664a2f7 commit 266efe2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/app/main/src/appMenuBuilder.spec.ts
Expand Up @@ -343,7 +343,7 @@ describe('AppMenuBuilder', () => {
expect(editMenuTemplate).toHaveLength(7);

const viewMenuTemplate = appMenuTemplate[2].submenu;
expect(viewMenuTemplate).toHaveLength(6);
expect(viewMenuTemplate).toHaveLength(7);

const convoMenuTemplate = appMenuTemplate[3].submenu;
expect(convoMenuTemplate).toHaveLength(1);
Expand Down Expand Up @@ -413,7 +413,7 @@ describe('AppMenuBuilder', () => {

it('should initialize and update the debugMenu item', async () => {
const viewMenu = await AppMenuBuilder.initViewMenu();
expect(viewMenu.submenu[5]).toEqual({
expect(viewMenu.submenu[6]).toEqual({
checked: false,
click: jasmine.any(Function),
id: 'debugMode',
Expand All @@ -422,11 +422,11 @@ describe('AppMenuBuilder', () => {
});

mockGetApplicationMenu = () => ({
getMenuItemById: () => viewMenu.submenu[5],
getMenuItemById: () => viewMenu.submenu[6],
});

AppMenuBuilder.updateDebugModeViewMenuItem(DebugMode.Sidecar);
expect(viewMenu.submenu[5]).toEqual({
expect(viewMenu.submenu[6]).toEqual({
checked: true,
click: jasmine.any(Function),
id: 'debugMode',
Expand Down
1 change: 1 addition & 0 deletions packages/app/main/src/appMenuBuilder.ts
Expand Up @@ -437,6 +437,7 @@ export class AppMenuBuilder {
{ role: 'zoomout' },
{ type: 'separator' },
{ role: 'togglefullscreen' },
{ role: 'toggledevtools' },
{
type: 'checkbox',
checked: debugMode === DebugMode.Sidecar,
Expand Down

0 comments on commit 266efe2

Please sign in to comment.