Merge 0ec9970 into 7c49920

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [client] Allow text to be selected in webchat in PR [#1351](https://github.com/Microsoft/BotFramework-Emulator/pull/1351)
 - [client] Pass along user name to webchat in PR [#1353](https://github.com/Microsoft/BotFramework-Emulator/pull/1353)
 - [client] Do not render certain activities in webchat in PR [#1363](https://github.com/Microsoft/BotFramework-Emulator/pull/1363)
+- [core] Fixed issue with contentUrl for attachments in PR [#1364](https://github.com/Microsoft/BotFramework-Emulator/pull/1364)
 
 ## v4.3.0 - 2019 - 03 - 04
 ### Added

packages/emulator/core/src/directLine/middleware/upload.ts

@@ -81,6 +81,7 @@ export default function upload(botEmulator: BotEmulator) {
           uploads = [uploads];
         }
         if (uploads && uploads.length) {
+          const serviceUrl = await botEmulator.getServiceUrl(botEndpoint.botUrl);
           activity.attachments = [];
           uploads.forEach(upload1 => {
             const name = (upload1 as any).name || 'file.dat';
@@ -95,7 +96,6 @@ export default function upload(botEmulator: BotEmulator) {
               thumbnailBase64: contentBase64,
             };
             const attachmentId = botEmulator.facilities.attachments.uploadAttachment(attachmentData);
-            const serviceUrl = botEmulator.getServiceUrl(botEndpoint.botUrl);
             const attachment: Attachment = {
               name,
               contentType: type,