Skip to content

Commit

Permalink
Fixed a screen reader issue with the dialog close button.
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyanziano committed Sep 6, 2019
1 parent 54aa2cc commit de257ae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Fixed
- [main] Fixed bug where opening a chat via URL was sending two conversation updates in PR [1735](https://github.com/microsoft/BotFramework-Emulator/pull/1735)
- [main] Fixed an issue where the Emulator was incorrectly sending the conversation id instead of an emulated OAuth token in PR [1738](https://github.com/microsoft/BotFramework-Emulator/pull/1738)
- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
- [client] Fixed various accessibility issues in PRs:
- [1775](https://github.com/microsoft/BotFramework-Emulator/pull/1775)
- [1776](https://github.com/microsoft/BotFramework-Emulator/pull/1776)
Expand All @@ -38,7 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1840](https://github.com/microsoft/BotFramework-Emulator/pull/1840)
- [1842](https://github.com/microsoft/BotFramework-Emulator/pull/1842)
- [1843](https://github.com/microsoft/BotFramework-Emulator/pull/1843)
- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
- [1845](https://github.com/microsoft/BotFramework-Emulator/pull/1845)

## v4.5.2 - 2019 - 07 - 17
## Fixed
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/ui-react/src/widget/dialog/dialog.tsx
Expand Up @@ -57,9 +57,9 @@ export class Dialog extends Component<ModalProps, {}> {
<div className={`${className} ${styles.dialog} dialog`} onKeyDown={this.bodyKeyDownHandler}>
<header className={`${titleClassName}`} role="heading">
{title}
<button className={styles.cancelButton} aria-label="Close" onClick={this.props.cancel} />
<div className={styles.cancelButtonOutline} role="presentation"></div>
</header>
<button className={styles.cancelButton} aria-label="Close" onClick={this.props.cancel} />
<div className={styles.cancelButtonOutline} role="presentation"></div>
{filterChildren(children, child => hmrSafeNameComparison(child.type, DialogFooter, true))}
{filterChildren(children, child => hmrSafeNameComparison(child.type, DialogFooter))}
</div>
Expand Down

0 comments on commit de257ae

Please sign in to comment.