Fixed a11y issue with SR narration of conversation toolbar.

* fix position announcement * Update changelog
microsoft · Oct 22, 2019 · ffa96e8 · ffa96e8
1 parent 2717295
commit ffa96e8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -74,6 +74,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - [1927](https://github.com/microsoft/BotFramework-Emulator/pull/1927)
   - [1933](https://github.com/microsoft/BotFramework-Emulator/pull/1933)
   - [1934](https://github.com/microsoft/BotFramework-Emulator/pull/1934)
+  - [1935](https://github.com/microsoft/BotFramework-Emulator/pull/1935)
 
  - [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
  - [client] Implemented HTML app menu for Windows in PR [1893](https://github.com/microsoft/BotFramework-Emulator/pull/1893) 

diff --git a/packages/app/client/src/ui/editor/emulator/emulator.tsx b/packages/app/client/src/ui/editor/emulator/emulator.tsx
@@ -305,14 +305,13 @@ export class Emulator extends React.Component<EmulatorProps, {}> {
                   onClick={this.onStartOverClick}
                   buttonRef={this.setRestartButtonRef}
                 />
-                <div role="menuitem">
-                  <button
-                    className={`${styles.saveIcon} ${styles.toolbarIcon || ''}`}
-                    onClick={this.onExportTranscriptClick}
-                  >
-                    Save transcript
-                  </button>
-                </div>
+                <button
+                  role={'menuitem'}
+                  className={`${styles.saveIcon} ${styles.toolbarIcon || ''}`}
+                  onClick={this.onExportTranscriptClick}
+                >
+                  Save transcript
+                </button>
               </>
             )}
           </ToolBar>

diff --git a/packages/sdk/ui-react/src/widget/splitButton/splitButton.tsx b/packages/sdk/ui-react/src/widget/splitButton/splitButton.tsx
@@ -93,7 +93,7 @@ export class SplitButton extends React.Component<SplitButtonProps, SplitButtonSt
           >
             <span>{defaultLabel}</span>
           </button>
-          <div className={styles.separator} />
+          <div className={styles.separator} aria-hidden={'true'} />
           <button
             aria-label={defaultLabel}
             className={styles.caretButton + expandedClass}