Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending Conversation/conversationUpdate (user added) appears to make multiple calls. #991

Closed
johnataylor opened this issue Oct 15, 2018 · 1 comment
Closed

Sending Conversation/conversationUpdate (user added) appears to make multiple calls. #991

johnataylor opened this issue Oct 15, 2018 · 1 comment
Assignees
@justinwilaby
Labels
Bug Your classic code defect

Comments

@johnataylor
Copy link
Member

Version

Bot Framework Emulator (V4 PREVIEW)
version: 4.0.0-preview.4025

Describe the bug

Using the send activity ConversationUpdate add member seems to make 8 calls.
Remove member seems to make no calls. Same for other activity types.

Sending these activities would be very useful for bot developers.

To Reproduce

  1. got to top menu "Conversation"
  2. sub menu "conversationUpdate" "user added"
  3. observe main window - and see activities arriving in a test bot.

Expected behavior

The appropriate activity exchanges (2 for member added for example.)
@justinwilaby
Copy link
Contributor

I saw this today while testing other bits and it seems there is an issue with a middleware in the emulator or possibly with webchat somewhere. I'll investigate and determine risk and impact.

@justinwilaby justinwilaby self-assigned this Oct 16, 2018
@justinwilaby justinwilaby added Bug Your classic code defect v4.2 labels Oct 16, 2018
@justinwilaby justinwilaby mentioned this issue Oct 25, 2018
Closed
justinwilaby pushed a commit that referenced this issue Oct 26, 2018
Merge branch 'v4' into jwilaby/#991-multiple-conversation-update-calls
2b9fa9b
vishwacsena added a commit that referenced this issue Oct 26, 2018
@vishwacsena
Merge pull request #1045 from Microsoft/jwilaby/#991-multiple-convers…
f753387 
…ation-update-calls

Jwilaby/#991 multiple conversation update calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinwilaby justinwilaby

Labels
Bug Your classic code defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnataylor @justinwilaby