Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select client certificate dialog #1011

Merged
merged 22 commits into from Oct 22, 2018
Merged

select client certificate dialog #1011

merged 22 commits into from Oct 22, 2018

Conversation

corinagum
Copy link
Contributor

still missing:

  • styling
  • unit tests
  • e2e hookup

Corina and others added 21 commits October 17, 2018 16:10
update toolbar buttons to comply with design
d521109
fix merge conflicts
e906158
Style cleanup including scrunching caused by generic document
8652916
camel case to kebab cleanup for scss files
cee8093
camel case to kebab case cleanup
abea4eb
style regression fix
ed3bc74
nav bar icon adjustments
2646ef0
navBar badge notification adjustment
faf8a8f
Minor style fix to welcome page
bb54bf3
Update botframework-webchat package
733ed1e
Merge branch 'v4' into corinagum/895-designpolish
1e71d7f
webchat package.json versioning fix
cb30212
edit merge conflicts
51f6066
Merge pull request #1003 from Microsoft/corinagum/895-designpolish
1b7588d 
Design Polish
@carlosscastro
Auth: fix consent blocking MSFt employees sign in
b642b53
Fixed the getSignInLink function
6b26021
Merge pull request #1005 from Microsoft/ccastro/fix-consent-auth
9d82834 
Auth: fix consent blocking MSFt employees sign in
Merge branch 'v4' into jwilaby/oauth-card-fix
984b0c9
Merge pull request #1008 from Microsoft/jwilaby/oauth-card-fix
e1e5f9e 
Fixed the getSignInLink function
Add clientCertSelectDialog for choosing login cert
615da5f
Merge branch 'v4' into corinagum/select-client-certificate
27a1255
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1044

  • 4 of 31 (12.9%) changed or added relevant lines in 4 files are covered.
  • 471 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-2.8%) to 43.426%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/commands/uiCommands.ts 0 2 0.0%
packages/app/client/src/ui/dialogs/clientCertSelectDialog/clientCertSelectDialogContainer.tsx 2 4 50.0%
packages/app/client/src/ui/dialogs/clientCertSelectDialog/clientCertSelectDialog.tsx 0 9 0.0%
packages/emulator/core/src/utils/oauthLinkEncoder.ts 2 16 12.5%
Files with Coverage Reduction New Missed Lines %
testSetup.js 1 66.67%
packages/app/client/src/data/action/azureAuthActions.ts 1 83.33%
packages/app/client/src/data/action/endpointServiceActions.ts 1 83.33%
packages/sdk/shared/built/ipc/channel.js 1 85.71%
packages/app/client/src/ipc.ts 1 41.67%
packages/sdk/shared/built/utils/bot.js 1 94.12%
packages/app/client/src/platform/commands/commandServiceImpl.ts 1 44.44%
packages/app/shared/built/utils.js 1 53.13%
packages/app/client/src/data/editorHelpers.ts 2 0.0%
packages/app/client/src/data/action/connectedServiceActions.ts 4 50.0%
Totals Coverage Status
Change from base Build 1021: -2.8%
Covered Lines: 3171
Relevant Lines: 6528
💛 - Coveralls

@justinwilaby
Copy link
Contributor

Once this is merged into select-client-certificate, we need to get unit tests in place and perform some general cleanup.

justinwilaby
justinwilaby approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge into select-client-certificate. Changes will be required before this can be merged into v4

packages/app/client/src/ui/dialogs/clientCertSelectDialog/clientCertSelectDialogContainer.tsx Outdated
@@ -0,0 +1,47 @@
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file extension should be .ts here

packages/app/client/src/ui/dialogs/clientCertSelectDialog/clientCertSelectDialog.tsx
@@ -0,0 +1,81 @@
import { Certificate } from 'electron';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests?

packages/app/client/src/commands/uiCommands.ts
@@ -133,4 +135,9 @@ export function registerCommands(commandRegistry: CommandRegistry) {
commandRegistry.registerCommand(UI.UpdateProgressIndicator, (value: ProgressIndicatorPayload) => {
store.dispatch(updateProgressIndicator(value));
});

commandRegistry.registerCommand(UI.ShowSelectCertDialog, (certs: Certificate[]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test?

@corinagum corinagum merged commit 51fb31c into select-client-certificate Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corinagum @coveralls @justinwilaby @carlosscastro