Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #873 - Tab labels #1084

Merged
merged 4 commits into from Nov 9, 2018
Merged

Fixes #873 - Tab labels #1084

merged 4 commits into from Nov 9, 2018

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Nov 7, 2018 •
edited

This PR resolves #873

also, cruft was removed and unit tests added.

@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited

Pull Request Test Coverage Report for Build 1283

  • 49 of 62 (79.03%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 54.985%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/shell/mdi/mdi.tsx 14 15 93.33%
packages/app/client/src/commands/emulatorCommands.ts 16 19 84.21%
packages/app/main/src/commands/emulatorCommands.ts 0 4 0.0%
packages/app/main/src/utils/parseActivitiesFromChatFile.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 1259: 0.1%
Covered Lines: 4361
Relevant Lines: 7156
💛 - Coveralls

tonyanziano
tonyanziano previously approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/app/client/src/data/reducer/editor.ts Outdated Show resolved Hide resolved
@justinwilaby justinwilaby merged commit 1777901 into master Nov 9, 2018
@justinwilaby justinwilaby deleted the jwilaby/#873-tab-label-update branch November 9, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@justinwilaby @coveralls @tonyanziano