Emulator: Auth with AADV1, update after consent and ARM delegated access #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1406
💛 - Coveralls |
carlosscastro
added a commit
that referenced
this pull request
Nov 20, 2018
Revert "Merge pull request #1113 from Microsoft/ccastro/authv2"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our app configuration has now been updated in terms of consent and ARM delegated access. This PR updates the resouce to the current ARM resource code.
Result: Single-FA and Multi-FA works again for Microsoft and Non-Microsoft users, see below for screenshots.
Pending: PIN, dongle and smart card not in this PR. The Certificate selection and support for PIN, dongle and smart card is in the ccastro/select-client-certificate branch. Now that this PR is going in, we'll merge master to that branch and close the loop on that work.
Demo 1: Hotmail Single-FA
Demo 2: Hotmail 2 FA with authenticator App on cell phone
Demo 3: Microsoft Multi-FA selection
Demo 4: Microsoft Phone 2 FA in progress
Demo 5: Microsoft account sign in success