Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1057 - Proxy support #1129

Merged
merged 2 commits into from Nov 28, 2018
Merged

Fixes #1057 - Proxy support #1129

merged 2 commits into from Nov 28, 2018

Conversation

justinwilaby
Copy link
Contributor

Resolves #1057

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1458

  • 13 of 15 (86.67%) changed or added relevant lines in 4 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 56.384%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/fetchProxy.ts 11 12 91.67%
packages/emulator/core/src/utils/oauthLinkEncoder.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/emulator/core/lib/botEmulator.js 7 47.06%
packages/emulator/core/lib/utils/oauthLinkEncoder.js 18 14.71%
Totals Coverage Status
Change from base Build 1453: 0.05%
Covered Lines: 4568
Relevant Lines: 7306
💛 - Coveralls

tonyanziano
tonyanziano approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one question regarding testing the proxy functionality on mock fetch calls.

packages/app/main/src/fetchProxy.spec.ts Show resolved Hide resolved
@justinwilaby justinwilaby merged commit 6fc6eb8 into master Nov 28, 2018
@justinwilaby justinwilaby deleted the jwilaby/#1057-proxy-support branch December 21, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinwilaby @coveralls @tonyanziano