Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Generic service support #1138

Merged
merged 4 commits into from Dec 5, 2018
Merged

Added Generic service support #1138

merged 4 commits into from Dec 5, 2018

Conversation

justinwilaby
Copy link
Contributor

resolves #936

@coveralls
Copy link

coveralls commented Dec 3, 2018 •
edited

Pull Request Test Coverage Report for Build 1481

  • 56 of 59 (94.92%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 56.971%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/data/sagas/servicesExplorerSagas.ts 3 6 50.0%
Totals Coverage Status
Change from base Build 1479: 0.2%
Covered Lines: 4693
Relevant Lines: 7441
💛 - Coveralls

tonyanziano
tonyanziano previously approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/kvPair.tsx Outdated Show resolved Hide resolved
@justinwilaby justinwilaby merged commit 77fb2de into master Dec 5, 2018
@justinwilaby justinwilaby deleted the jwilaby/#936-generic-service branch December 5, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emulator - add support for generic service configuration
3 participants
@justinwilaby @coveralls @tonyanziano