Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication: Move to first party app and change flow to implicit flow. #1139

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

carlosscastro
Copy link
Member

Authentication changes:

  • Move to Bot Framework first party app
  • On the app side, requested a change that jst got approved to allow implicit flow
  • Implicit flow docs: oauth spec and aad docs.
  • Implicit flow returns the access token directly but to a reply uri approved by the app. We just intercept the request and extract the token from the url

Demos

Microsoft account

2 factor auth in progress
msft_2fa

Phone authentication
msft_phone

Querying luis models after successful auth
luis_quer

Querying QnA resources
qna_query

Hotmail account

Hotmail MFA password
hotmail_mfa

Hotmail device authentication with Authenticator app
hotmail_mfa2

Live specific remember account to bypass 2fa in the future
hotmail_mfa_remember

Successful signin iwth hotmail
success

@coveralls
Copy link

coveralls commented Dec 3, 2018

Pull Request Test Coverage Report for Build 1478

  • 11 of 12 (91.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 56.727%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/services/azureAuthWorkflowService.ts 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
packages/app/main/src/services/azureAuthWorkflowService.ts 2 76.0%
Totals Coverage Status
Change from base Build 1470: -0.04%
Covered Lines: 4646
Relevant Lines: 7394

💛 - Coveralls

justinwilaby
justinwilaby previously approved these changes Dec 3, 2018
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants