Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-applying lost code changes #1162

Merged
merged 2 commits into from Dec 10, 2018
Merged

Re-applying lost code changes #1162

merged 2 commits into from Dec 10, 2018

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Dec 10, 2018 •
edited

resolves #936

tonyanziano
tonyanziano approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@coveralls
Copy link

coveralls commented Dec 10, 2018 •
edited

Pull Request Test Coverage Report for Build 1524

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.329%
Totals Coverage Status
Change from base Build 1522: 0.0%
Covered Lines: 4801
Relevant Lines: 7544
💛 - Coveralls

@justinwilaby justinwilaby merged commit 8bacc53 into master Dec 10, 2018
@justinwilaby justinwilaby deleted the jwilaby/#936-generic-service branch December 10, 2018 19:06
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emulator - add support for generic service configuration
3 participants
@justinwilaby @coveralls @tonyanziano