Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge v4.2.1 into master #1187

Closed
wants to merge 15 commits into from
Closed

Merge v4.2.1 into master #1187

wants to merge 15 commits into from

Conversation

tonyanziano
Copy link
Contributor

Syncing 4.2.1 feature changes with master

tonyanziano and others added 15 commits December 17, 2018 08:57
@tonyanziano
Added missing https-proxy-agent dependency.
608056f
Merge pull request #1176 from Microsoft/toanzian/#1175-proxy-agent
6e34d4b 
Added missing https-proxy-agent dependency.
Revert "Added missing https-proxy-agent dependency."
0db38d3
@tonyanziano
Merge pull request #1178 from Microsoft/revert-1176-toanzian/#1175-pr…
e00d746 
…oxy-agent

Revert "Added missing https-proxy-agent dependency."
@tonyanziano
Added missing https-proxy-agent dependency for proxy support.
8bdfe3f
Merge pull request #1179 from Microsoft/toanzian/#1175-proxy
38b6e29 
Added missing dependency for proxy support
@tonyanziano
Significantly improved performance of UpdateConversationMenu command.
0c48ad8
@tonyanziano
Converted AppMenuBuilder to class with static methods.
ffa88d5
@tonyanziano
First draft of AppMenuBuilder rewrite.
8295f82
@tonyanziano
Added tests.
6db2719
@tonyanziano
Fixed bad reference exception.
a9729df
@tonyanziano
Added tests for Mac.
6c6795c
@tonyanziano
Addressed PR comments.
6343e09
@tonyanziano
Removed unused code.
fd4ea57
@tonyanziano
Bumped version to 4.2.1
104408e
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1590

  • 77 of 82 (93.9%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 57.607%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/appMenuBuilder.ts 58 63 92.06%
Files with Coverage Reduction New Missed Lines %
packages/app/main/src/utils/getThemes.ts 1 90.0%
packages/app/main/src/utils/loadSettings.ts 1 79.07%
Totals Coverage Status
Change from base Build 1583: 0.2%
Covered Lines: 4867
Relevant Lines: 7598
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten Awaiting requested review from cwhitten

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonyanziano @coveralls