Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix step alignment issue on small viewports #1205

Merged
merged 1 commit into from Jan 2, 2019
Merged

fix step alignment issue on small viewports #1205

merged 1 commit into from Jan 2, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 2, 2019 •
edited

closes #1198

also fixes an issue where some links were being clipped on smaller view ports.

screen shot 2019-01-02 at 12 49 43 pm

@a-b-r-o-w-n
fix step alignment issue on small viewports
183e7bb 
also fixes an issue where some links were being clipped on smaller view ports.
corinagum
corinagum approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1668

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.29%
Totals Coverage Status
Change from base Build 1652: 0.0%
Covered Lines: 5020
Relevant Lines: 7749
💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n merged commit f3de91d into master Jan 2, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-step-alignment branch January 2, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@corinagum corinagum corinagum approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten

@compulim compulim Awaiting requested review from compulim

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

welcome page steps alignment issue with small viewport
4 participants
@a-b-r-o-w-n @coveralls @tonyanziano @corinagum