Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1196 - post to new conversation does not work #1211

Merged
merged 14 commits into from Jan 8, 2019

Conversation

justinwilaby
Copy link
Contributor

This PR fixes #1196 by resolving 500s received when posting to /v3/conversations and by opening a new live chat window upon successfully posting.

@coveralls
Copy link

coveralls commented Jan 7, 2019

Pull Request Test Coverage Report for Build 1733

  • 81 of 99 (81.82%) changed or added relevant lines in 4 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.9%) to 61.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/restServer.ts 32 35 91.43%
packages/emulator/core/src/conversations/middleware/createConversation.ts 21 24 87.5%
packages/app/main/src/ngrokService.ts 18 22 81.82%
packages/emulator/core/src/conversations/middleware/errorCondition/createConversationValidator.ts 10 18 55.56%
Files with Coverage Reduction New Missed Lines %
packages/emulator/core/src/utils/createResponse/error.ts 1 0.0%
packages/emulator/core/src/utils/sendErrorResponse.ts 1 81.82%
packages/emulator/core/lib/conversations/middleware/createConversation.js 11 20.93%
Totals Coverage Status
Change from base Build 1727: 1.9%
Covered Lines: 5334
Relevant Lines: 7822

💛 - Coveralls

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes requested to improve readability.

packages/app/main/src/restServer.ts Outdated Show resolved Hide resolved
packages/app/main/src/restServer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Andy's suggested changes on readability, but other than that it looks good to me. 👍

a-b-r-o-w-n
a-b-r-o-w-n previously approved these changes Jan 7, 2019
tonyanziano
tonyanziano previously approved these changes Jan 8, 2019
@justinwilaby justinwilaby force-pushed the jwilaby/#1196-fix-proactive-messaging branch from 36ae1ea to 752972e Compare January 8, 2019 19:20
@justinwilaby justinwilaby force-pushed the jwilaby/#1196-fix-proactive-messaging branch from 752972e to 423e73b Compare January 8, 2019 19:21
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you please squash your commits using the "Squash and Merge" option? You should be able to select it.

@justinwilaby justinwilaby merged commit a373890 into master Jan 8, 2019
@justinwilaby justinwilaby deleted the jwilaby/#1196-fix-proactive-messaging branch January 8, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST /v3/conversations ➡ InternalServerError: Cannot read property 'appid' of undefined
5 participants