New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #1196 - post to new conversation does not work #1211
Conversation
Pull Request Test Coverage Report for Build 1733
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor changes requested to improve readability.
packages/emulator/core/src/conversations/middleware/createConversation.ts
Outdated
Show resolved
Hide resolved
packages/emulator/core/src/conversations/middleware/createConversation.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Andy's suggested changes on readability, but other than that it looks good to me. 👍
36ae1ea
to
752972e
Compare
752972e
to
423e73b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - can you please squash your commits using the "Squash and Merge" option? You should be able to select it.
This PR fixes #1196 by resolving 500s received when posting to
/v3/conversations
and by opening a new live chat window upon successfully posting.