Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let git handle line endings instead of editor #1222

Merged
merged 2 commits into from
Jan 11, 2019
Merged

let git handle line endings instead of editor #1222

merged 2 commits into from
Jan 11, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 11, 2019 •
edited
Loading

This makes developing on multiple platforms easier by allowing git to control which line endings to use on the host system.

EDIT: also adds CODEOWNERS file for automatic review requests.

@coveralls
Copy link

coveralls commented Jan 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1762

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.13%
Totals Coverage Status
Change from base Build 1750: 0.0%
Covered Lines: 5352
Relevant Lines: 7845
💛 - Coveralls

tonyanziano
tonyanziano approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@a-b-r-o-w-n
Copy link
Contributor Author

@tonyanziano Travis is reporting successful builds, but github did not get updated. Any ideas on how to fix?

@a-b-r-o-w-n a-b-r-o-w-n merged commit b207b98 into master Jan 11, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the line-endings branch January 11, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a-b-r-o-w-n @coveralls @tonyanziano