Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃拝 integrate prettier and eslint #1240

Merged
merged 43 commits into from Jan 17, 2019

Conversation

Projects
None yet
4 participants
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Jan 17, 2019

closes #1235

"parser": "typescript",
"trailingComma": "es5",
"singleQuote": true
}

This comment has been minimized.

@a-b-r-o-w-n

a-b-r-o-w-n Jan 17, 2019

Author Contributor

We can debate here on the prettier formatting options. https://prettier.io/docs/en/options.html

"prettier --write",
"git add"
]
},

This comment has been minimized.

@a-b-r-o-w-n

a-b-r-o-w-n Jan 17, 2019

Author Contributor

We can potentially expand this to other file types, including markdown and css

@cwhitten

This comment has been minimized.

Copy link
Member

cwhitten commented Jan 17, 2019

For any observers wondering why eslint instead of tslint, see this issue on the TypeScript project

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 17, 2019

Pull Request Test Coverage Report for Build 1844

  • 1020 of 1361 (74.94%) changed or added relevant lines in 203 files are covered.
  • 236 unchanged lines in 48 files lost coverage.
  • Overall coverage increased (+0.2%) to 61.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/commands/botCommands.ts 24 25 96.0%
packages/app/client/src/commands/notificationCommands.ts 0 1 0.0%
packages/app/client/src/data/chatHelpers.ts 0 1 0.0%
packages/app/client/src/data/editorHelpers.ts 3 4 75.0%
packages/app/client/src/data/reducer/progressIndicator.ts 0 1 0.0%
packages/app/client/src/data/sagas/resourcesSagas.ts 4 5 80.0%
packages/app/client/src/ui/debug/storeVisualizer.tsx 2 3 66.67%
packages/app/client/src/ui/dialogs/azureLoginFailedDialog/azureLoginFailedDialogContainer.ts 1 2 50.0%
packages/app/client/src/ui/dialogs/azureLoginPromptDialog/azureLoginPromptDialogContainer.ts 1 2 50.0%
packages/app/client/src/ui/dialogs/azureLoginSuccessDialog/azureLoginSuccessDialogContainer.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
packages/app/client/src/data/action/explorerActions.ts 1 66.67%
packages/emulator/core/src/utils/createResponse/error.ts 1 0.0%
packages/app/client/src/data/sagas/resourcesSagas.ts 1 86.27%
packages/emulator/core/lib/directLine/middleware/startConversation.js 1 17.78%
packages/sdk/main/built/index.js 1 78.95%
packages/sdk/main/built/ipc/index.js 1 78.95%
packages/app/main/src/utils/writeFile.ts 1 12.5%
packages/emulator/core/lib/conversations/middleware/createConversation.js 1 19.23%
packages/app/client/src/data/action/connectedServiceActions.ts 1 91.67%
packages/app/client/src/commands/notificationCommands.ts 1 0.0%
Totals Coverage Status
Change from base Build 1838: 0.2%
Covered Lines: 5517
Relevant Lines: 7983

馃挍 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n force-pushed the prettier branch from 88c444f to fc0b947 Jan 17, 2019

@justinwilaby
Copy link
Contributor

justinwilaby left a comment

LGTM. Looking forward to giving this a whirl!

@a-b-r-o-w-n

This comment has been minimized.

Copy link
Contributor Author

a-b-r-o-w-n commented Jan 17, 2019

@tonyanziano and I both did a regression pass which uncovered two unrelated issues (related to #1219 ). Merging this and will file new issues against the regressions.

@a-b-r-o-w-n a-b-r-o-w-n merged commit d71c03c into master Jan 17, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 61.998%
Details
license/cla All CLA requirements met.
Details

@a-b-r-o-w-n a-b-r-o-w-n deleted the prettier branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.