Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃拝 integrate prettier and eslint #1240

Merged
merged 43 commits into from Jan 17, 2019
Merged

馃拝 integrate prettier and eslint #1240

merged 43 commits into from Jan 17, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 17, 2019 •
edited

closes #1235

a-b-r-o-w-n
a-b-r-o-w-n commented Jan 17, 2019
View reviewed changes
.prettierrc
"parser": "typescript",
"trailingComma": "es5",
"singleQuote": true
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can debate here on the prettier formatting options. https://prettier.io/docs/en/options.html

a-b-r-o-w-n
a-b-r-o-w-n commented Jan 17, 2019
View reviewed changes
package.json
"prettier --write",
"git add"
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can potentially expand this to other file types, including markdown and css

@cwhitten
Copy link
Member

For any observers wondering why eslint instead of tslint, see this issue on the TypeScript project

@coveralls
Copy link

coveralls commented Jan 17, 2019 •
edited

Pull Request Test Coverage Report for Build 1844

  • 1020 of 1361 (74.94%) changed or added relevant lines in 203 files are covered.
  • 236 unchanged lines in 48 files lost coverage.
  • Overall coverage increased (+0.2%) to 61.998%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/commands/botCommands.ts 24 25 96.0%
packages/app/client/src/commands/notificationCommands.ts 0 1 0.0%
packages/app/client/src/data/chatHelpers.ts 0 1 0.0%
packages/app/client/src/data/editorHelpers.ts 3 4 75.0%
packages/app/client/src/data/reducer/progressIndicator.ts 0 1 0.0%
packages/app/client/src/data/sagas/resourcesSagas.ts 4 5 80.0%
packages/app/client/src/ui/debug/storeVisualizer.tsx 2 3 66.67%
packages/app/client/src/ui/dialogs/azureLoginFailedDialog/azureLoginFailedDialogContainer.ts 1 2 50.0%
packages/app/client/src/ui/dialogs/azureLoginPromptDialog/azureLoginPromptDialogContainer.ts 1 2 50.0%
packages/app/client/src/ui/dialogs/azureLoginSuccessDialog/azureLoginSuccessDialogContainer.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
packages/app/client/src/data/action/explorerActions.ts 1 66.67%
packages/emulator/core/src/utils/createResponse/error.ts 1 0.0%
packages/app/client/src/data/sagas/resourcesSagas.ts 1 86.27%
packages/emulator/core/lib/directLine/middleware/startConversation.js 1 17.78%
packages/sdk/main/built/index.js 1 78.95%
packages/sdk/main/built/ipc/index.js 1 78.95%
packages/app/main/src/utils/writeFile.ts 1 12.5%
packages/emulator/core/lib/conversations/middleware/createConversation.js 1 19.23%
packages/app/client/src/data/action/connectedServiceActions.ts 1 91.67%
packages/app/client/src/commands/notificationCommands.ts 1 0.0%
Totals Coverage Status
Change from base Build 1838: 0.2%
Covered Lines: 5517
Relevant Lines: 7983
馃挍 - Coveralls

cwhitten and others added 21 commits January 17, 2019 11:27
@a-b-r-o-w-n
lint & prettify app main
19cd490
@a-b-r-o-w-n
lint & prettify app client
2c64141
@a-b-r-o-w-n
apply new lint rules
3c04dab
@a-b-r-o-w-n
do not lint scss.d.ts files
43c07d7
@a-b-r-o-w-n
fix conflicts from master
32a890e
@a-b-r-o-w-n
lint & prettify luis client
d0be2df
@a-b-r-o-w-n
enable parsing of jsx in js files
3ada833
@a-b-r-o-w-n
lint & prettify debug extension
8251875
@a-b-r-o-w-n
lint & prettify qna extension
24915b6
@a-b-r-o-w-n
lint & prettify emulator core
c5cc011
@a-b-r-o-w-n
lint & prettify emulator cli
531011e
@a-b-r-o-w-n
add top level lint:fix script
5bddc35
@a-b-r-o-w-n
correctly represent return value
f6f5c6e
@a-b-r-o-w-n
remove license from generated files
2b1dc32
@a-b-r-o-w-n
revert converting to import
7b7a388
@a-b-r-o-w-n
use defined class to export singleton
6bc20f1 
fixes typescript errors
@a-b-r-o-w-n
get tests passing
1eb600a
@a-b-r-o-w-n
remove outdated comment
5dbb129
@a-b-r-o-w-n
convert eslintrc to js modules
d0bce8e 
The .eslintrc file is being deprecated in favor of explicit extensions.
https://eslint.org/docs/user-guide/configuring#configuration-file-formats
@a-b-r-o-w-n
fix merge conflicts
a807ad3
@a-b-r-o-w-n
ignore scss typings
5d9ee05
@a-b-r-o-w-n
do not bail when running lint scripts
fc0b947
justinwilaby
justinwilaby approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking forward to giving this a whirl!

@a-b-r-o-w-n
Copy link
Contributor Author

@tonyanziano and I both did a regression pass which uncovered two unrelated issues (related to #1219 ). Merging this and will file new issues against the regressions.

@a-b-r-o-w-n a-b-r-o-w-n merged commit d71c03c into master Jan 17, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the prettier branch January 17, 2019 22:10
ZYBRAXIS
ZYBRAXIS reviewed May 27, 2019
View reviewed changes
Copy link

@ZYBRAXIS ZYBRAXIS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<DeploymentConfiguration PackageId=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYBRAXIS ZYBRAXIS ZYBRAXIS left review comments

@justinwilaby justinwilaby justinwilaby approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to prettier & eslint
5 participants
@a-b-r-o-w-n @cwhitten @coveralls @justinwilaby @ZYBRAXIS