#1237 - updated implementation to use API instead of internals #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwilaby
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
Pull Request Test Coverage Report for Build 1909
💛 - Coveralls |
a-b-r-o-w-n
requested changes
Jan 22, 2019
packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/dialogs/openBotDialog/openBotDialogContainer.ts
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
previously requested changes
Jan 22, 2019
a-b-r-o-w-n
reviewed
Jan 22, 2019
packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
requested changes
Jan 24, 2019
a-b-r-o-w-n
requested changes
Jan 24, 2019
packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.spec.tsx
Outdated
Show resolved
Hide resolved
packages/emulator/core/src/conversations/middleware/conversationsMiddleware.spec.ts
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
previously approved these changes
Jan 24, 2019
a-b-r-o-w-n
approved these changes
Jan 24, 2019
|
Merged anyway. Coverage is expected to decrease with this change |
This was referenced Nov 5, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows a reduction in code coverage because not all packages were represented in the coverage analysis previously. No coverage was lost with this PR (several more unit tests are in fact included) but it is now accounting for coverage as a whole which reduces coverage % from before.