Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data url links will now prompt to save to disk. #1315

Merged
merged 1 commit into from Feb 13, 2019
Merged

Data url links will now prompt to save to disk. #1315

merged 1 commit into from Feb 13, 2019

Conversation

tonyanziano
Copy link
Contributor

Fixes #1130

===

image

@coveralls
Copy link

coveralls commented Feb 13, 2019 •
edited

Pull Request Test Coverage Report for Build 2074

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 51.889%
Totals Coverage Status
Change from base Build 2066: 0.3%
Covered Lines: 4619
Relevant Lines: 8317
💛 - Coveralls

justinwilaby
justinwilaby approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/app/client/src/hyperlinkHandler.ts
a.href = url;
a.download = '';
a.click();
a.remove();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsequential since the element is never being added to the dom. It can probably be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the remove?!?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it when I inevitably have to update the branch once the azure gov fix goes into master.

@justinwilaby justinwilaby merged commit 374742d into master Feb 13, 2019
@justinwilaby justinwilaby deleted the toanzian/#1130-dl-link branch February 13, 2019 21:04
tonyanziano added a commit that referenced this pull request Feb 13, 2019
@tonyanziano
Revert "Data url links will now prompt to save to disk. (#1315)"
09e83ae 
This reverts commit 374742d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonyanziano @coveralls @justinwilaby