Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data url links will now prompt to save to disk. #1315

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@tonyanziano
Copy link
Contributor

tonyanziano commented Feb 13, 2019

Fixes #1130

===

image

@tonyanziano tonyanziano force-pushed the toanzian/#1130-dl-link branch from df7b0ac to 7c62020 Feb 13, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 13, 2019

Pull Request Test Coverage Report for Build 2074

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 51.889%

Totals Coverage Status
Change from base Build 2066: 0.3%
Covered Lines: 4619
Relevant Lines: 8317

💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/#1130-dl-link branch from 7c62020 to 7cc7f6f Feb 13, 2019

@justinwilaby
Copy link
Contributor

justinwilaby left a comment

LGTM

a.href = url;
a.download = '';
a.click();
a.remove();

This comment has been minimized.

@justinwilaby

justinwilaby Feb 13, 2019

Contributor

This is inconsequential since the element is never being added to the dom. It can probably be removed.

This comment has been minimized.

@tonyanziano

tonyanziano Feb 13, 2019

Author Contributor

remove the remove?!?

This comment has been minimized.

@tonyanziano

tonyanziano Feb 13, 2019

Author Contributor

I'll change it when I inevitably have to update the branch once the azure gov fix goes into master.

@justinwilaby justinwilaby merged commit 374742d into master Feb 13, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@justinwilaby justinwilaby deleted the toanzian/#1130-dl-link branch Feb 13, 2019

tonyanziano added a commit that referenced this pull request Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.