Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests to emulator/core #1321

Merged
merged 2 commits into from Feb 20, 2019
Merged

Added tests to emulator/core #1321

merged 2 commits into from Feb 20, 2019

Conversation

tonyanziano
Copy link
Contributor

Also added a VSCode debugging task for the currently open Jest file.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2094

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.04%) to 54.926%
Totals Coverage Status
Change from base Build 2092: 3.04%
Covered Lines: 4865
Relevant Lines: 8313
💛 - Coveralls

justinwilaby
justinwilaby approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@justinwilaby justinwilaby merged commit b05ab1e into master Feb 20, 2019
@justinwilaby justinwilaby deleted the toanzian/test-bonanza branch February 20, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonyanziano @coveralls @justinwilaby