Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to export transcript messages from trace activities when in debug mode #1452

Merged
merged 5 commits into from Apr 24, 2019

Conversation

Projects
None yet
4 participants
@justinwilaby
Copy link
Contributor

commented Apr 23, 2019

No description provided.

@justinwilaby justinwilaby force-pushed the jwilaby/export-trace-transcripts branch from 21ac438 to ce90330 Apr 23, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 24, 2019

Coverage Status

Coverage increased (+0.02%) to 56.843% when pulling f4d1167 on jwilaby/export-trace-transcripts into 014fa59 on master.

@justinwilaby justinwilaby changed the title Added the ability to extract messages from trace activities when in debug mode Added the ability to export transcript messages from trace activities when in debug mode Apr 24, 2019

@cwhitten
Copy link
Member

left a comment

When a .bot file has been opened in Emulator mode, then switch modes to Sidecar mode and have a conversation via the external channel and subsequently save the transcript, the directory to save the transcript is incorrect. It defaults to what appears to be the activeBot's path. Please address this.

@justinwilaby justinwilaby requested a review from cwhitten Apr 24, 2019

@justinwilaby justinwilaby force-pushed the jwilaby/export-trace-transcripts branch from ac69e32 to 2c4ca36 Apr 24, 2019

@tonyanziano
Copy link
Contributor

left a comment

LGTM. Tested locally and Chris' concern seems to be fixed.

Verbal communication - the issue raised has been solved

@justinwilaby justinwilaby merged commit 0d4f107 into master Apr 24, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 56.843%
Details
license/cla All CLA requirements met.
Details

@justinwilaby justinwilaby deleted the jwilaby/export-trace-transcripts branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.