[ISSUE#1699] Introduce a context menu -> copy JSON in the JSON inspector #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denscollo
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
tonyanziano
previously approved these changes
Sep 4, 2019
| @@ -365,6 +366,11 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> { | |||
|
|
|||
| private accessoryClick = (event: MouseEvent<HTMLButtonElement>): void => { | |||
| const id = event.currentTarget.name; | |||
|
|
|||
| if (id == 'copyJson') { | |||
| return Electron.clipboard.writeText(JSON.stringify(this.state.inspectObj, null, 2)); | |||
There was a problem hiding this comment.
Minor nitpick:
Would prefer if the import statement was:
import { clipboard } from 'electron'
and this line was:
return clipboard.writeText(...)
This was referenced Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1699 #1694
Description
Allows the users to copy the activities in JSON format using the "Copy json" button placed in the inspector panel or using the context menu items for the activities in the chat session.
Changes made
Testing
The next image shows how the "Copy json" button works.
Also, this one shows the context menu enabled for the activities in default mode.
