Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1963] Fixed input border color contrast issue. #2016

Merged
merged 2 commits into from Dec 9, 2019
Merged

[#1963] Fixed input border color contrast issue. #2016

merged 2 commits into from Dec 9, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Dec 8, 2019 •
edited

#1963

===

  • Input border has been changed from #C8C8C8 to #888 which achieves a color contrast ratio of 3.2:1

image

  • Cancel button contrast was fixed in a previous, separate PR

image

@coveralls
Copy link

coveralls commented Dec 8, 2019 •
edited

Coverage Status

Coverage remained the same at 68.758% when pulling 9fe9730 on toanzian/acc-#1963 into 483f53f on master.

corinagum
corinagum previously approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tonyanziano tonyanziano merged commit 084cec7 into master Dec 9, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1963 branch December 9, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonyanziano @coveralls @corinagum